Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company-box making emacs unusable after latest changes in company-mode #313

Closed
CsBigDataHub opened this issue Jul 9, 2021 · 5 comments
Closed

Comments

@CsBigDataHub
Copy link
Contributor

CsBigDataHub commented Jul 9, 2021

company-mode has new updates -
https://github.com/company-mode/company-mode/blob/master/NEWS.md
and company-box is not compatible with those changes. This is breaking emacs.

Is it possible to remove company-box and just leverage icon support for company-mode it self?

company-mode/company-mode#1070

Also search for icon in https://github.com/company-mode/company-mode/blob/master/NEWS.md for new icon functions

@CsBigDataHub
Copy link
Contributor Author

Icon support in company-mode can be achieved by
company-format-margin-function #'company-detect-icons-margin

@CsBigDataHub
Copy link
Contributor Author

created PR to fix company-box
sebastiencs/company-box#168

@seagle0128
Copy link
Owner

seagle0128 commented Jul 9, 2021

I saw your PR of company-box. Hope the author to merge it soon.
Well, I know company support icons now, basically support vscode icons. company-box supports both icons and help docs, so I prefer it. With my fine-tuning, it looks great IMO.

If company-box is not maintained actively, perhaps I will consider other solution. Your ideas are welcome!

@CsBigDataHub
Copy link
Contributor Author

CsBigDataHub commented Jul 9, 2021

With my fine-tuning, it looks great IMO.

Yes it does 😄

If company-box is not maintained actively, perhaps I will consider other solution.

completely agree.

PR sebastiencs/company-box#168 is pushed to melpa. closing the issue.

@seagle0128
Copy link
Owner

seagle0128 commented Jul 10, 2021

Thanks! Glad it has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants