Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Icons for Evil states and flymake status are cropped #632

Closed
3 tasks done
Dickby opened this issue May 13, 2023 · 15 comments
Closed
3 tasks done

[Bug] Icons for Evil states and flymake status are cropped #632

Dickby opened this issue May 13, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@Dickby
Copy link
Contributor

Dickby commented May 13, 2023

Thank you for the bug report

  • I am using the latest version of doom-modeline related packages.
  • I checked FAQ.
  • You may also try reproduce the issue using clean environment and minimal configurations with
    the command emacs -Q.

Bug description

As the title states, the icons are cropped similar to the clock face that was fixed.
The Evil state icon is not always cropped, often after changing the evil state it is displayed correctly, after redisplaying it cropped again most of the time.

Steps to reproduce

Use doom-modeline and evil/flymake.

Expected behavior

Icons should not be cropped.

OS

Linux

Emacs Version

29 (dev)

Emacs Configurations

No response

Error callstack

No response

Anything else

Under Emacs Versions i chose 29(dev), the version i use is really GNU Emacs 30.0.50 of 2023-05-13, but there is not an option for that.

@Dickby Dickby added the bug Something isn't working label May 13, 2023
@Dickby
Copy link
Contributor Author

Dickby commented May 13, 2023

I fixed the displaying of the evil-state icons by setting the faces :weight to 'thin after looking inside the fix for #626

@seagle0128
Copy link
Owner

Can you please provide screenshots?

@Dickby
Copy link
Contributor Author

Dickby commented May 15, 2023

Shure!

  1. As stated the evil-state-icon is fine if i use 'thin for the :weight attribute. Without that:
    evil-state-icon
  2. The flymake-icon:
    flymake-icon

@seagle0128
Copy link
Owner

seagle0128 commented May 15, 2023

@rainstormstudio Could you please take a look at this issue? I didn't observe this issue on my env. I guess it's related to the font and/or platform. All are mdicons.

@whame
Copy link
Contributor

whame commented Jun 5, 2023

Check that you are not overriding any faces in your config (e.g. custom themes). I believe this is occurring when you have :weight bold on faces for the modeline. Setting :weight normal should fix this.

@seagle0128
Copy link
Owner

seagle0128 commented Jun 6, 2023

Check that you are not overriding any faces in your config (e.g. custom themes). I believe this is occurring when you have :weight bold on faces for the modeline. Setting :weight normal should fix this.

I agree. Generally bold weight causes this issue. @Dickby Please check.

@sewe2000
Copy link

I have the same issue. Besides, doom-modeline-mode slows my emacs configuration terribly.

@sewe2000
Copy link

Changing font weight didn't help.

@seagle0128
Copy link
Owner

seagle0128 commented Jun 25, 2023

I have the same issue. Besides, doom-modeline-mode slows my emacs configuration terribly.

Please use emacs -Q to reproduce and provide more info.

@sewe2000
Copy link

sewe2000 commented Jul 6, 2023

How should I use emacs -Q to solve my problem?
When I start emacs using my init file the icon on the left ( indicating evil-mode status ) is just an empty square. Then emacs becomes very slow for example when I'm typing. When I disable doom-modeline-mode in the M-x prompt the speed becomes normal. It happens in every buffer except Dashboard.

@sewe2000
Copy link

sewe2000 commented Jul 6, 2023

Here's my doom-modeline configuration in init.el:

(use-package nerd-icons)
;; Setting up doom-modeline
(use-package doom-modeline
 :ensure t
 :config
 (if (facep 'mode-line-active)
 (set-face-attribute 'mode-line-active nil :family "Symbols Nerd Fonts Mono"
 :height 120 :weight 'normal) ; For 29+
(set-face-attribute 'mode-line nil :family "Symbols Nerd Fonts Mono"
                                 :height 120 :weight 'normal))
(set-face-attribute 'mode-line-inactive nil :family "Symbols Nerd Fonts Mono"
                               :height 120 :weight 'normal)
(doom-modeline-mode 1))

;; doom themes
 (use-package doom-themes
 :init
(load-theme 'doom-city-lights t)) ;; loading the theme

@seagle0128
Copy link
Owner

@sewe2000 What OS are you using? And I don't think it's a good idea to customize mode-line faces with nerd fonts.

How should I use emacs -Q to solve my problem?

  1. Use emacs -Q to start.
  2. Eval the snippet below.
(package-initialize)
(setq inhibit-compacting-font-caches t) ;; If you are using Windows
(require 'nerd-icons)
(require 'doom-modeline)
(doom-modeline-mode 1)

@sewe2000
Copy link

sewe2000 commented Jul 7, 2023

I'm using Arch Linux. After starting via emacs -Q and evaluating the snippet the problem has gone, so I assume the fault is on the side of my config.

@seagle0128
Copy link
Owner

So I am closing this issue. If you still encounter the issue , please feel free to reopen it.

@LukeDRussell
Copy link

Thanks for answering this @seagle0128 . I had the same issue in a different context. Fix was the same.

I had installed Solarized Emacs. I couldn't figure out how to stop it from apply bold in the modeline, so I just disabled the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants