feat: Add pagination to /devices/list #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle |
4 tasks
Neiva07
reviewed
Feb 17, 2025
| @@ -52,7 +83,38 @@ export default withRouteSpec({ | |||
| ) | |||
| } | |||
|
|
|||
| devices = sortBy(devices, ["created_at", "device_id"]) | |||
There was a problem hiding this comment.
Yes, but I did this intentionally here for now as we will need to factor all of this core logic out for pagination support on all endpoints. As part of that, every query will need to ensure it's ordered.
| page_cursor: z | ||
| .string() | ||
| .optional() | ||
| .nullable() |
There was a problem hiding this comment.
why nullable? What case the client passes null in this field?
There was a problem hiding this comment.
It makes type DX much better, otherwise users have to use "?? undefined" or add null checks. But null / undefined are basically the same here.
|
I found nullable is easier for type DX. There is no functional difference in this case and otherwise you have to do a lot of |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andrii-balitskyi
approved these changes
Feb 19, 2025
razor-x
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.