feat: Add NoiseSensorDeviceDetails
#628
Conversation
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/DeviceDetails/NoiseSensorDeviceDetails.tsx
Outdated
Show resolved
Hide resolved
| <DetailSection | ||
| label={t.noiseThresholds} | ||
| tooltipContent={ | ||
| device.device_type === 'minut_sensor' ? ( |
There was a problem hiding this comment.
Why does minut have special behavior here?
There was a problem hiding this comment.
Not sure—it is specified in the design: https://www.figma.com/file/WTdzEh4CudGdQFOtuVR3Eh/Thermostat%2FNoise-components?type=design&node-id=3996-10671&mode=design&t=GfLxqO8DBwAaTIaZ-4
| export function NoiseThresholdsList({ | ||
| device, | ||
| }: NoiseThresholdsListProps): JSX.Element { | ||
| const { noiseThresholds, isInitialLoading } = useNoiseThresholds({ |
There was a problem hiding this comment.
Why are we passing isInitialLoading around instead of showing a loading state for the entire section?
Are we using or can we use the loading behavior / loading toasts like we do elsewhere? It's ok if we address this as a follow up PR, but I thought we had standardized the component loading behavior.
There was a problem hiding this comment.
I wanted to avoid an additional ternary operator on Content. But that's a good point, I can add the loading toast as well. There's no design for this, and it will overlay the device card at the top. I'll address this in a subsequent PR if you don't mind.
Co-authored-by: Evan Sosenko <evan@getseam.com>
Adds read-only
NoiseSensorDeviceDetailscomponent.