Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modularize my.location and remove tz.time.via_location #19

Closed
seanbreckenridge opened this issue Jan 30, 2022 · 3 comments
Closed

modularize my.location and remove tz.time.via_location #19

seanbreckenridge opened this issue Jan 30, 2022 · 3 comments

Comments

@seanbreckenridge
Copy link
Owner

Can put the individual sources for location behind import_source blocks, so that people can use one of the location sources here without having to mess with the files to prevent certain imports

Then, use that location.all in tz.time.via_location -- can remove the file from here (since its currently overriden due to editable rules), and PR the location.all to the main repo
@seanbreckenridge
Copy link
Owner Author

related issue karlicoss/HPI#154

@seanbreckenridge
Copy link
Owner Author

modularized ip some 4a87b6a

@seanbreckenridge seanbreckenridge mentioned this issue Apr 16, 2022
Merged
@seanbreckenridge
Copy link
Owner Author

Should be solved by karlicoss/HPI#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanbreckenridge