Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.1 seems to require ansi_term 0.9 #12

Closed
ignatenkobrain opened this issue Feb 8, 2018 · 6 comments
Closed

0.2.1 seems to require ansi_term 0.9 #12

ignatenkobrain opened this issue Feb 8, 2018 · 6 comments

Comments

@ignatenkobrain
Copy link
Contributor

Also there is no tag in repository...

@seanmonstar
Copy link
Owner

Yes it does, because 0.10 doesn't work on Windows MSVC. Is there a problem with an internal dependency needing an earlier version?

@ignatenkobrain
Copy link
Contributor Author

@seanmonstar we are trying very hard to avoid packaging multiple versions of crate and so far pretty-env-logger is the only one depending on 0.9 (while perfectly compiles with 0.10), so probably you can make windows-specific dependency on 0.9 while letting rest of the world using 0.10?

@seanmonstar
Copy link
Owner

That seems reasonable!

@ignatenkobrain
Copy link
Contributor Author

Or, better, to fix ansi_term :D

@seanmonstar
Copy link
Owner

Oh yea, definitely that is preferred. Several have tried, seems the author may be MIA: ogham/rust-ansi-term#31

Or perhaps, the dependency should swap from ansi_term to the crate the ripgrep uses. It also better detects if printing to a TTY or if being redirected to a file.

@seanmonstar
Copy link
Owner

OK, I've published v0.2.2 that uses ansi_term 0.10 on all except for windows + x86, which uses 0.9. Also added Travis and AppVeyor CI to ensure they both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants