-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.1 seems to require ansi_term 0.9 #12
Comments
Yes it does, because 0.10 doesn't work on Windows MSVC. Is there a problem with an internal dependency needing an earlier version? |
@seanmonstar we are trying very hard to avoid packaging multiple versions of crate and so far pretty-env-logger is the only one depending on 0.9 (while perfectly compiles with 0.10), so probably you can make windows-specific dependency on 0.9 while letting rest of the world using 0.10? |
That seems reasonable! |
Or, better, to fix ansi_term :D |
Oh yea, definitely that is preferred. Several have tried, seems the author may be MIA: ogham/rust-ansi-term#31 Or perhaps, the dependency should swap from ansi_term to the crate the ripgrep uses. It also better detects if printing to a TTY or if being redirected to a file. |
OK, I've published v0.2.2 that uses ansi_term 0.10 on all except for windows + x86, which uses 0.9. Also added Travis and AppVeyor CI to ensure they both work. |
Also there is no tag in repository...
The text was updated successfully, but these errors were encountered: