[Feature Request] Default log level

[pheki]

In env_logger it's possible to provide a default log level by using:

env_logger::from_env(Env::default().default_filter_or("info")).init();

Would you consider adding this feature (or maybe accepting a PR)?

[JMLX42]

Here is how we do it as a workaround:

if let Err(_) = std::env::var("SMARTSHAPE_CLI_LOG") {
    std::env::set_var("SMARTSHAPE_CLI_LOG", "warn");
}

[pheki]

@promethe42 nice workaround!

The only caveat is that if set RUST_LOG to a specific module, the default log level is lost

(also clippy recommends .is_err() instead of let Err(_))

[RalfJung]

The only caveat is that if set RUST_LOG to a specific module, the default log level is lost

I think the env_logger snippet has the same issue. At least, the default_filter_or docs say

Use the default environment variable to read the filter from.

If the variable is not set, the default value will be used.

[pheki]

Hmmmmmmmmmmmm that's true, didn't realize that

[jpmckinney]

I don't need the env vars to work (I have a CLI with a repeatable verbose flag) so I'm doing something like:

use log::LevelFilter;

pretty_env_logger::formatted_builder().filter_level(LevelFilter::Warn).init();

[link2xt]

This should be upstreamed to https://github.com/rust-cli/env_logger

In deltachat/deltachat-core-rust#5112 I did:

    pretty_env_logger::formatted_timed_builder()
        .parse_default_env()
        .filter_module("deltachat_repl", log::LevelFilter::Info)
        .init();

This parses RUST_LOG, then unconditionally overwrites the level for deltachat_repl module. What is missing is doing this only if deltachat_repl module is not already set (by .parse_default_env()).

Upstream issue is at rust-cli/env_logger#162

[Skgland]

This should be upstreamed to https://github.com/rust-cli/env_logger

In deltachat/deltachat-core-rust#5112 I did:

    pretty_env_logger::formatted_timed_builder()
        .parse_default_env()
        .filter_module("deltachat_repl", log::LevelFilter::Info)
        .init();

This parses RUST_LOG, then unconditionally overwrites the level for deltachat_repl module. What is missing is doing this only if deltachat_repl module is not already set (by .parse_default_env()).

Upstream issue is at rust-cli/env_logger#162

Wouldn't this be fixed by swapping the filter_module and parse_default_env call changing it to

    pretty_env_logger::formatted_timed_builder()
        .filter_module("deltachat_repl", log::LevelFilter::Info)
        .parse_default_env()
        .init();

that way the env variable should be able to overwrite the default.