Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reqwest ignores ProxyOverride parameter on windows #1444

Open
vegansk opened this issue Jan 20, 2022 · 8 comments
Open

reqwest ignores ProxyOverride parameter on windows #1444

vegansk opened this issue Jan 20, 2022 · 8 comments
Labels
E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@vegansk
Copy link

vegansk commented Jan 20, 2022

reqwest doesn't use HKCU\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyOverride parameter. If user adds local resources to exceptions list, reqwest will ignore it and will try to use proxy for those resources.

@seanmonstar
Copy link
Owner

Is this a thing that curl or other client libraries look at? If so, I'd welcome a PR!

@seanmonstar seanmonstar added the E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. label Jan 20, 2022
@citreae535
Copy link

Hi, I've done some research on this issue:

  1. curl does not auto-detect windows system proxy, see this to-do item
  2. The semantics of ProxyOverride is described here
  3. Python's standard library has an implementation for parsing ProxyOverride. But it does not strictly conform to the specifications

@Bi0T1N
Copy link

Bi0T1N commented Aug 6, 2023

What's the status on this? I see there was a PR but it was closed by the submitter; probably because no one gave feedback or merged it.

@zanieb
Copy link

zanieb commented Feb 19, 2025

We have a report of this over in astral-sh/uv#11640 — is there still willingness to look at a pull request?

@Fizcko
Copy link

Fizcko commented Feb 20, 2025

hi @seanmonstar

is it possible to have a look on this issue ?

Thanks

@seanmonstar
Copy link
Owner

This isn't something that I can work on, but a PR is welcome. It vaguely looks like it's similar to parsing it and making a NoProxy from the values?

@Fizcko
Copy link

Fizcko commented Feb 20, 2025

It vaguely looks like it's similar to parsing it and making a NoProxy from the values?

Yes it is

@Fizcko
Copy link

Fizcko commented Feb 21, 2025

@seanmonstar as requested a PR to fix this issue #2559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants