You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When trying to set nodelay on a ClientBuilder (e.g. reqwest::Client::builder().tcp_nodelay(true)), the resulting clients that are built do not have TCP_NODELAY set on the sockets they use. This happens when an http connection is made and either the default features are enabled or the rustls-tls feature is enabled. Also note that tcp_nodelay(true) works as intended when default features are disabled and rustls-tls is not enabled.
Here is where ClientBuilder creates the HttpConnector it eventually passes to one of the Connector::new functions towards the end of that scope without ever configuring the HttpConnector beyond setting a timeout. Only one of those Connector::new functions sets TCP_NODELAYhere, and that only get called when the __tls feature is disabled. An easy fix would be to simply add that line to the other Connector:new functions such as under this line.
The text was updated successfully, but these errors were encountered:
When trying to set
nodelay
on aClientBuilder
(e.g.reqwest::Client::builder().tcp_nodelay(true)
), the resulting clients that are built do not haveTCP_NODELAY
set on the sockets they use. This happens when anhttp
connection is made and either thedefault
features are enabled or therustls-tls
feature is enabled. Also note thattcp_nodelay(true)
works as intended whendefault
features are disabled andrustls-tls
is not enabled.Here is where
ClientBuilder
creates theHttpConnector
it eventually passes to one of theConnector::new
functions towards the end of that scope without ever configuring theHttpConnector
beyond setting a timeout. Only one of thoseConnector::new
functions setsTCP_NODELAY
here, and that only get called when the__tls
feature is disabled. An easy fix would be to simply add that line to the otherConnector:new
functions such as under this line.The text was updated successfully, but these errors were encountered: