Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit default generic type value when re-exporting types #8

Closed
jeparlefrancais opened this issue Dec 20, 2023 · 0 comments · Fixed by #11
Closed

Omit default generic type value when re-exporting types #8

jeparlefrancais opened this issue Dec 20, 2023 · 0 comments · Fixed by #11

Comments

@jeparlefrancais
Copy link
Contributor

When re-exporting a generic type that has a default type value, the default value may not be re-exported so it has to be omitted:

export type ReactElement<Props = Object, ElementType = any> = module.ReactElement<Props, ElementType>

If Object is not exported (and not a standard type), the default value should be removed:

export type ReactElement<Props, ElementType = any> = module.ReactElement<Props, ElementType>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit default type for generic type parameters when re-exporting types seaofvoices/npmluau
1 participant
@jeparlefrancais