New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with natxet\CssMin #10

Open

clemgrim opened this issue Oct 5, 2015 · 0 comments

clemgrim commented Oct 5, 2015

In my project I incllude this library and natxet\CssMin with composer

I have this error when calling PhpWee\Minify::html($html);

 PHP Catchable fatal error: Argument 1 passed to aCssMinifierFilter::__construct() must be an instance of CssMinifier, instance of PHPWee\\CssMinifier given, called in [...]/vendor/searchturbine/phpwee-php-minifier/src/CssMin/CssMin.php on line 1994 and defined in [...]/vendor/natxet/CssMin/src/CssMin.php on line 250

Can you please add CssMin and JsMin as composer dependencies instead of making a code copy ?
I think it will be a better practice

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment