Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datasource,rm): insert on update executor #456

Merged
merged 12 commits into from
Feb 18, 2023

Conversation

iSuperCoder
Copy link
Contributor

@iSuperCoder iSuperCoder commented Jan 15, 2023

Closes #441

What this PR does:

Which issue(s) this PR fixes:

Fixes #441

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #456 (1eaea85) into master (437f712) will decrease coverage by 0.04%.
The diff coverage is 34.48%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   39.05%   39.02%   -0.04%     
==========================================
  Files         144      145       +1     
  Lines        9120     9638     +518     
==========================================
+ Hits         3562     3761     +199     
- Misses       5264     5565     +301     
- Partials      294      312      +18     
Impacted Files Coverage Δ
pkg/client/client.go 0.00% <0.00%> (ø)
pkg/client/config.go 61.66% <ø> (ø)
pkg/datasource/sql/exec/at/at_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/delete_executor.go 23.23% <0.00%> (-0.24%) ⬇️
.../datasource/sql/exec/select_for_update_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/parser/parser_factory.go 50.00% <0.00%> (-0.95%) ⬇️
pkg/datasource/sql/tx_at.go 23.52% <ø> (-2.19%) ⬇️
pkg/datasource/sql/types/executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/types/sql.go 0.00% <0.00%> (ø)
.../sql/undo/builder/mysql_update_undo_log_builder.go 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Fixes #441

pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
pkg/datasource/sql/exec/at/insert_on_update_executor.go Outdated Show resolved Hide resolved
@iSuperCoder iSuperCoder requested review from luky116 and georgehao and removed request for luky116 and georgehao February 14, 2023 01:26
@luky116 luky116 merged commit 62b932b into apache:master Feb 18, 2023
@iSuperCoder iSuperCoder deleted the feature/issue-441 branch March 4, 2023 08:30
georgehao pushed a commit to georgehao/seata-go that referenced this pull request May 7, 2023
* refactor(datasource,rm): insert on update executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate and test insert on update sql
8 participants