Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize the golang ci lint #523

Closed
wants to merge 0 commits into from
Closed

Conversation

Finkyky
Copy link
Contributor

@Finkyky Finkyky commented Mar 16, 2023

What this PR does:

1、调整golangci.yml结构
2、添加一些linter
3、添加部分issues相关的配置

Which issue(s) this PR fixes:

Fixes #479

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #523 (c0e7002) into master (7358494) will decrease coverage by 0.29%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   36.54%   36.26%   -0.29%     
==========================================
  Files         162      162              
  Lines       11166    11234      +68     
==========================================
- Hits         4081     4074       -7     
- Misses       6738     6792      +54     
- Partials      347      368      +21     
Impacted Files Coverage Δ
pkg/datasource/sql/async_worker.go 0.00% <0.00%> (ø)
pkg/datasource/sql/at_resource_manager.go 0.00% <0.00%> (ø)
pkg/datasource/sql/conn_xa.go 34.13% <0.00%> (+0.40%) ⬆️
.../sql/undo/builder/mysql_delete_undo_log_builder.go 32.30% <ø> (ø)
.../sql/undo/builder/mysql_insert_undo_log_builder.go 50.24% <ø> (ø)
...mysql_insertonduplicate_update_undo_log_builder.go 47.46% <0.00%> (-0.45%) ⬇️
...ndo/builder/mysql_multi_delete_undo_log_builder.go 54.03% <0.00%> (ø)
...e/sql/undo/builder/mysql_multi_undo_log_builder.go 0.00% <0.00%> (ø)
.../sql/undo/builder/mysql_update_undo_log_builder.go 0.00% <ø> (ø)
pkg/datasource/sql/util/convert.go 3.75% <0.00%> (ø)
... and 14 more

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@kaori-seasons kaori-seasons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(ci): optimize the golang ci lint
3 participants