Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix some problems with zstd compressor and add the version of the kotlin-maven-plugin #4220

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Dec 21, 2021

bugfix: fix some problems with zstd compressor and add the version of the kotlin-maven-plugin
BUG修复:修复一些关于zstd压缩的问题。

  1. ZstdCompressor的包名不正确,修正掉。
  2. seata-all中,未添加zstd的依赖,最终合并后的all中,并未包含zstd的几个类。

另外,做了一些优化:

  1. 补充kotlin-maven-plugin插件的版本号,否则打包时会出现警告。
  2. 排除 *.proto ,不打包进jar中,因为已经编译成 .class 文件了。
  3. 排除 additional-spring-configuration-metadata.json文件,不打包进jar中,因为没什么用处。
    我在spring-boot开源项目中提了issue,并得到了回答:
    Automatically filter additional-spring-configuration-metadata.json from Spring Boot-built archives spring-projects/spring-boot#27430

all/pom.xml Show resolved Hide resolved
@wangliang181230 wangliang181230 changed the title bugfix: fix some problems with zstd compressor and add the version of the kotlin-maven-plugin bugfix: fix some problems with zstd compressor and add the version of the kotlin-maven-plugin Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #4220 (91ab0ef) into develop (24e38be) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4220   +/-   ##
==========================================
  Coverage      48.98%   48.98%           
- Complexity      3774     3775    +1     
==========================================
  Files            720      720           
  Lines          24001    24001           
  Branches        2927     2926    -1     
==========================================
+ Hits           11757    11758    +1     
+ Misses         11042    11040    -2     
- Partials        1202     1203    +1     
Impacted Files Coverage Δ
.../java/io/seata/compressor/zstd/ZstdCompressor.java 100.00% <ø> (ø)
...c/main/java/io/seata/compressor/zstd/ZstdUtil.java 90.00% <ø> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 47.84% <0.00%> (-0.54%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.56% <0.00%> (-0.44%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@slievrly
Copy link
Member

The version of dependency or plug-in suggests centralized maintenance.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230
Copy link
Contributor Author

The version of dependency or plug-in suggests centralized maintenance.

I'll do it in a new PR

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege caohdgege added this to the 1.5.0 milestone Dec 22, 2021
@caohdgege caohdgege added type: bug Category issues or prs related to bug. type: optimize labels Dec 22, 2021
@caohdgege caohdgege merged commit 14907c2 into apache:develop Dec 22, 2021
@wangliang181230 wangliang181230 deleted the bugfix/zstd branch January 11, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug. type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants