bugfix: row size gt 1000 cause error in oracle #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slievrly
reviewed
Jan 5, 2022
core/src/main/java/io/seata/core/store/db/sql/lock/AbstractLockStoreSql.java
Show resolved
Hide resolved
|
@chiangcho Pls resolve conflict |
Codecov Report
@@ Coverage Diff @@
## develop #4266 +/- ##
=============================================
- Coverage 48.84% 48.84% -0.01%
- Complexity 3797 3800 +3
=============================================
Files 724 724
Lines 24211 24238 +27
Branches 2961 2972 +11
=============================================
+ Hits 11826 11839 +13
- Misses 11154 11159 +5
- Partials 1231 1240 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
register branch and release lock failed when the size of rows that modified is greater than 1000 in oracle
Ⅱ. Does this pull request fix one issue?
fixes #3946
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews