Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : check if table meta cache should be refreshed in AT mode #5395

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Feb 28, 2023

#4734

(cherry picked from commit 28b3413)

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #5395 (0f1f8af) into 2.x (5aa6c29) will decrease coverage by 0.05%.
The diff coverage is 56.14%.

❗ Current head 0f1f8af differs from pull request most recent head 4e44b6d. Consider uploading reports for the commit 4e44b6d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5395      +/-   ##
============================================
- Coverage     48.81%   48.77%   -0.05%     
+ Complexity     4341     4338       -3     
============================================
  Files           775      776       +1     
  Lines         27391    27432      +41     
  Branches       3406     3410       +4     
============================================
+ Hits          13372    13380       +8     
- Misses        12629    12657      +28     
- Partials       1390     1395       +5     
Impacted Files Coverage Δ
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 78.34% <ø> (ø)
...n/java/io/seata/rm/datasource/DataSourceProxy.java 76.59% <33.33%> (-3.80%) ⬇️
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 51.85% <50.00%> (-5.30%) ⬇️
...m/datasource/sql/struct/TableMetaCacheFactory.java 52.63% <50.00%> (-22.37%) ⬇️
...ta/rm/datasource/exception/TableMetaException.java 66.66% <80.00%> (ø)
...o/seata/rm/datasource/sql/struct/TableRecords.java 68.18% <100.00%> (+1.20%) ⬆️
...ource/sql/struct/cache/AbstractTableMetaCache.java 82.35% <0.00%> (-2.95%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 77.12% <0.00%> (-2.32%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 45.45% <0.00%> (-0.42%) ⬇️
...erver/storage/file/session/FileSessionManager.java 61.78% <0.00%> (+0.63%) ⬆️
... and 2 more

@slievrly slievrly changed the title bugfix : check if table meta cache should be refreshed in AT mode #4734 bugfix : check if table meta cache should be refreshed in AT mode Feb 28, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How to stop the refresh thread after the dataSource is closed?
  2. How to close the refresh thread after dataSource overwriting.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bughue Please improve it in the next pr.

@slievrly slievrly merged commit 86c1c5d into apache:2.x Feb 28, 2023
@@ -40,7 +40,7 @@ Seata 是一款开源的分布式事务解决方案,提供高性能和简单
- [[#5355](https://github.com/seata/seata/pull/5355)] 修复自定义context-path时的问题
- [[#5362](https://github.com/seata/seata/pull/5362)] 修复当TC端回滚返回RollbackFailed时,自定义FailureHandler的方法未执行
- [[#5372](https://github.com/seata/seata/pull/5372)] 修复客户侧事务提交前超时未执行hook和failureHandler的问题

- [[#4734](https://github.com/seata/seata/pull/4734)] 修复AT模式下新增字段产生的字段找不到
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr code incorrect.

@wangliang181230 wangliang181230 added this to the 2.0.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants