Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some scripts related to Apollo #5927

Merged

Conversation

wangliang181230
Copy link
Contributor

optimize: optimize some scripts related to Apollo
优化一些与 Apollo 相关的脚本。

@wangliang181230 wangliang181230 added this to the 1.8.0 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5927 (922d1bd) into develop (357f8e8) will increase coverage by 0.05%.
Report is 81 commits behind head on develop.
The diff coverage is 69.90%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5927      +/-   ##
=============================================
+ Coverage      48.79%   48.85%   +0.05%     
+ Complexity      4176     4168       -8     
=============================================
  Files            743      793      +50     
  Lines          26617    28003    +1386     
  Branches        3327     3417      +90     
=============================================
+ Hits           12989    13681     +692     
- Misses         12225    12896     +671     
- Partials        1403     1426      +23     
Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
.../src/main/java/io/seata/common/util/BlobUtils.java 60.00% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/PageUtil.java 50.00% <ø> (ø)
...ava/io/seata/compressor/deflater/DeflaterUtil.java 80.64% <100.00%> (ø)
.../main/java/io/seata/config/ConfigurationCache.java 73.33% <100.00%> (-0.75%) ⬇️
...c/main/java/io/seata/core/context/RootContext.java 46.77% <ø> (ø)
...seata/core/exception/TransactionExceptionCode.java 100.00% <100.00%> (ø)
...o/seata/core/protocol/AbstractIdentifyRequest.java 78.57% <100.00%> (+8.57%) ⬆️
.../seata/core/protocol/AbstractIdentifyResponse.java 75.00% <100.00%> (-6.49%) ⬇️
... and 116 more

... and 72 files with indirect coverage changes

@wangliang181230
Copy link
Contributor Author

wangliang181230 commented Oct 16, 2023

@funky-eyes @slievrly PTAL

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 971d1de into apache:develop Oct 16, 2023
6 checks passed
@wangliang181230 wangliang181230 deleted the optimize-script-apollo-config branch October 17, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants