Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix some configurations that are not deprecated show "Deprecated" #5971

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

capthua
Copy link
Contributor

@capthua capthua commented Oct 30, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5965

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5971 (48f41cd) into 2.x (6d4ab48) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5971      +/-   ##
============================================
- Coverage     48.08%   48.07%   -0.01%     
+ Complexity     4614     4612       -2     
============================================
  Files           911      911              
  Lines         31285    31285              
  Branches       3768     3768              
============================================
- Hits          15042    15041       -1     
- Misses        14727    14728       +1     
  Partials       1516     1516              

see 3 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Please add change log to 2.0.0.md

@funky-eyes funky-eyes added this to the 2.0.0 milestone Oct 30, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/seata-spring-boot-starter seata-spring-boot-starter module labels Oct 30, 2023
@funky-eyes funky-eyes merged commit 64c5b8a into apache:2.x Oct 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/seata-spring-boot-starter seata-spring-boot-starter module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated: Please configure to 'seata.transport.rpcRmRequestTimeout'&rpc-tm-request-timeout
3 participants