Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Duplicate id #1940

Open
1 task done
anneliev opened this issue Jan 23, 2025 · 0 comments
Open
1 task done

Dropdown: Duplicate id #1940

anneliev opened this issue Jan 23, 2025 · 0 comments

Comments

@anneliev
Copy link

Does the component already exist

  • I confirm that I have checked if the component already exists in any of the Green libraries

For which framework/library you are requesting the component

Angular

Description

In rendered ngg-dropdown there are elements with ids, for example
<gds-field-base-2d2e21 slot="trigger" id="field" gds-element="gds-field-base" aria-expanded="false" gds-aria-haspopup="dialog"> , gds-listbox, label and a button.
This creates duplicate ids when you have more than one dropdown in a form or on a page.

Who will benefit from this feature?

Everyone, both those with assistive technology and "regular" users.

Anything else?

There shouldn't be any duplicate ids in the code. Maybe you can use CoPilots suggestion and use uuid generator? 😊🤖

@EldRoos EldRoos changed the title ngg-dropdown: Duplicate id Dropdown: Duplicate id Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants