Awesome!

[rfay]

This is great - I've subscribed to everything.

Some notes:

• To get this promoted to "official" it needs meaningful tests.
• Please add to the README links and description of what opensearch is (is it an elasticsearch fork?). People (like me) might not have heard of it. And explain what role it has in a project, and give a link to it. If it's an elasticsearch fork, then should you have started by forking https://github.com/drud/ddev-elasticsearch ? That would make things a lot easier. Is it then just a one-word change? I'm afraid that maintaining two in parallel that are really the same thing could be a waste of energy.
• To get this promoted to "official" when it's ready you would commit to maintenance, create an issue in the ddev queue, and we'd get it moved to the drud org.
• Locking the image to a particular minor release like 1.2.4 will probably not be the best way to maintain this.

I'm sure we'll talk more. Thanks for the initiative on this!

[rfay]

Overall, it seems like this should be re-done as a fork of ddev-elasticsearch, then it could be updated when ddev-elasticsearch changes.

[sebastian-ehrling]

Hi @rfay
I have renamed this repo and will delete it shortly. i've create a new repository with a fork of ddev-elasticsearch See here:
https://github.com/sebastian-ehrling/ddev-opensearch

I will also edit the readme soon.
Yes i can and will maintain this addon :)

[rfay]

Maybe you can move this issue over to the new repo, thanks.

[sebastian-ehrling]

Hi @rfay
i've completed the readme and add some informations about opensearch. I hope this will be ok?
Currently in the official docker hub there is no latest Tag of version 1.2 available. Which version would you have in mind?

[rfay]

I recommend the tag "2", looks like their most current (will always be 2.x)? Does it work or not? Alternately, the tag "1" will always be latest 1.x. See https://hub.docker.com/r/opensearchproject/opensearch/tags

Thankfully both of them have both amd64 and arm64 images.

You'll be happier in the long term if you add something with a little more substance to the tests, https://github.com/sebastian-ehrling/ddev-opensearch/blob/main/tests/test.bats (I do see that ddev-elasticsearch doesn't have more than that, but maybe you can come up with a little something?)

[rfay]

Regardless, when you're ready, let's get this promoted. I do think a longer-lived tag (1 or 2) will be good.

[rfay]

I'd like to see this get promoted; people will be happy to have it.

Right now, the tests are all failing, and have been failing as long as I can see. We don't want that happening!

Also, the tests have been turned off by github; you'll want to look at the .github in the template to see how to fix that, perhaps compare against recent commits in ddev-elasticsearch.

I'd sure love to see this get some love and get the tests working and enabled, thanks!

I'm baffled why it doesn't show up in ddev get --list --all. It seems to have the right label, and other things far more recent show up.

Edit: Turns out that the github search results are paged, and ddev never anticipated there would be so many add-ons.

• ddev get --list --all is not returning all available unofficial add-ons ddev/ddev#4795