Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backward compatibility workaround for old PHPUnit versions #100

Closed
sebastianbergmann opened this issue May 8, 2020 · 2 comments
Closed

Remove backward compatibility workaround for old PHPUnit versions #100

sebastianbergmann opened this issue May 8, 2020 · 2 comments
Assignees
@sebastianbergmann

Comments

@sebastianbergmann
Copy link
Owner

Differ::__construct() should only accept DiffOutputBuilderInterface arguments, #66 needs to be reverted. This breaks backward compatibility and must wait for the next major version.
@sebastianbergmann sebastianbergmann self-assigned this May 8, 2020
@SpacePossum
Copy link
Contributor

@sebastianbergmann feel free to ping me here if you want me to prepare a PR

@sebastianbergmann
Copy link
Owner Author

Thank you, @SpacePossum, for offering but I will do this myself when "the time is right".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @SpacePossum