You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to submit a PR, but am not certain how to structure the tests as they with 99% certainty require some level of mocking (php.ini reading) I think.
Are you OK with a more elaborate test setup to allow mocking things or are you comfortable with allowing soft failures in case some INI settings are not adjustable for some test cases? I know this is a relatively small library and adding boilerplate for mocking might seem overkill.
The thing I would like to tackle with my PR is the possibility to have Xdebug enabled, but code coverage disabled, leading to runtime errors when one could instead try PCOV for coverage in that case.
The text was updated successfully, but these errors were encountered:
Hello.
I want to submit a PR, but am not certain how to structure the tests as they with 99% certainty require some level of mocking (php.ini reading) I think.
Are you OK with a more elaborate test setup to allow mocking things or are you comfortable with allowing soft failures in case some INI settings are not adjustable for some test cases? I know this is a relatively small library and adding boilerplate for mocking might seem overkill.
The thing I would like to tackle with my PR is the possibility to have Xdebug enabled, but code coverage disabled, leading to runtime errors when one could instead try PCOV for coverage in that case.
The text was updated successfully, but these errors were encountered: