Multiline strings: skip internal lines

Author: Slamdunk

src/StaticAnalysis/ExecutableLinesFindingVisitor.php

@@ -54,6 +54,21 @@ public function __construct(string $source)
 
     public function enterNode(Node $node): void
     {
+        if ($node instanceof Node\Scalar\String_ ||
+            $node instanceof Node\Scalar\EncapsedStringPart
+        ) {
+            $startLine = $node->getStartLine() + 1;
+            $endLine   = $node->getEndLine() - 1;
+
+            if ($startLine <= $endLine) {
+                foreach (range($startLine, $endLine) as $line) {
+                    unset($this->executableLinesGroupedByBranch[$line]);
+                }
+            }
+
+            return;
+        }
+
         if ($node instanceof Node\Stmt\Declare_ ||
             $node instanceof Node\Stmt\DeclareDeclare ||
             $node instanceof Node\Stmt\Else_ ||

tests/_files/source_for_branched_exec_lines.php

@@ -506,6 +506,38 @@ public function withEarlyReturns()
         return;                             // +1
         $var = 2;                           // +1
     }
+    public function withMultilineStrings()
+    {
+        $var = 1;                           // +1
+        $singleQuote =                      // +1
+        'start                              // 0
+        a
+        $var
+        z
+        end';                               // 0
+        $doubleQuote =                      // +1
+        "start                              // 0
+        a
+        $var                                // 0
+        z
+        end";                               // 0
+        $nowDoc =                           // +1
+<<<'LINE_ADDED_IN_TEST'
+        start
+        a
+        $var
+        z
+        end
+LINE_ADDED_IN_TEST;                         // 0
+        $hereDoc =                          // +1
+<<<LINE_ADDED_IN_TEST
+        start                               // 0
+        a
+        $var                                // 0
+        z
+        end
+LINE_ADDED_IN_TEST;                         // 0
+    }
 }
 
 interface MyInterface

tests/tests/StaticAnalysis/ExecutableLinesFindingVisitorTest.php

@@ -12,6 +12,7 @@
 use function explode;
 use function file_get_contents;
 use function preg_match;
+use function strpos;
 use PhpParser\Lexer;
 use PhpParser\NodeTraverser;
 use PhpParser\ParserFactory;
@@ -65,6 +66,12 @@ private function doTestSelfDescribingAsset(string $filename): void
         $branch = 0;
 
         foreach ($linesFromSource as $lineNumber => $line) {
+            if (false !== strpos($line, 'LINE_ADDED_IN_TEST')) {
+                $expected[1 + $lineNumber] = $branch;
+
+                continue;
+            }
+
             if (1 !== preg_match('#^\s*[^/].+// (?<branchIncrement>[+-]?\d+)$#', $line, $matches)) {
                 continue;
             }