Skip to content

Commit 6a7bd25

Browse files
epdenoudensebastianbergmann
authored andcommitted
Add TestSuite class name to user message
1 parent 96c1264 commit 6a7bd25

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/Framework/TestSuite.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -756,8 +756,9 @@ public function run(TestResult $result = null): TestResult
756756
}
757757
}
758758
} catch (Throwable $t) {
759-
$error = new SyntheticError($t->getMessage(), 0, $t->getFile(), $t->getLine(), $t->getTrace());
760-
$test = new \Failure('tearDownAfterClass');
759+
$message = "Exception in {$this->name}::$afterClassMethod" . \PHP_EOL . $t->getMessage();
760+
$error = new SyntheticError($message, 0, $t->getFile(), $t->getLine(), $t->getTrace());
761+
$test = new \Failure($afterClassMethod);
761762

762763
$result->startTest($test);
763764
$result->addFailure($test, $error, 0);

tests/unit/Framework/TestSuiteTest.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,9 @@ public function testCreateTestForConstructorlessTestClass(): void
228228
TestSuite::createTest($reflection, 'TestForConstructorlessTestClass');
229229
}
230230

231+
/**
232+
* @testdox Handles exceptions in tearDownAfterClass()
233+
*/
231234
public function testTearDownAfterClassInTestSuite(): void
232235
{
233236
$suite = new TestSuite(\ExceptionInTearDownAfterClassTest::class);
@@ -238,6 +241,10 @@ public function testTearDownAfterClassInTestSuite(): void
238241

239242
/** @var TestFailure $failure */
240243
$failure = $this->result->failures()[0];
241-
$this->assertSame('throw Exception in tearDownAfterClass()', $failure->thrownException()->getMessage());
244+
$this->assertSame(
245+
'Exception in ExceptionInTearDownAfterClassTest::tearDownAfterClass' . \PHP_EOL .
246+
'throw Exception in tearDownAfterClass()',
247+
$failure->thrownException()->getMessage()
248+
);
242249
}
243250
}

0 commit comments

Comments
 (0)