adding file and lineno to output of 0 assertion test message

sebastianbergmann · Jul 7, 2018 · 80834b0 · 80834b0
1 parent c17423b
commit 80834b0
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 10 deletions.
diff --git a/src/Framework/TestResult.php b/src/Framework/TestResult.php
@@ -816,11 +816,24 @@ public function run(Test $test): void
         } elseif ($this->beStrictAboutTestsThatDoNotTestAnything &&
             !$test->doesNotPerformAssertions() &&
             $test->getNumAssertions() == 0) {
+            try {
+                $reflected = new \ReflectionClass($test);
+                $name      = $test->getName(false);
+
+                if ($name && $reflected->hasMethod($name)) {
+                    $reflected = $reflected->getMethod($name);
+                }
+                $message = \sprintf(
+                    "This test did not perform any assertions\n\n%s:%d",
+                    $reflected->getFileName(),
+                    $reflected->getStartLine()
+                );
+            } catch (\ReflectionException $exception) {
+                $message = 'This test did not perform any assertions';
+            }
             $this->addFailure(
                 $test,
-                new RiskyTestError(
-                    'This test did not perform any assertions'
-                ),
+                new RiskyTestError($message),
                 $time
             );
         } elseif ($this->beStrictAboutTestsThatDoNotTestAnything &&

diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -719,13 +719,7 @@ public function run(TestResult $result = null): TestResult
             $result->endTestSuite($this);
 
             return $result;
-        } catch (Throwable $_t) {
-            $t = $_t;
-        } catch (Exception $_t) {
-            $t = $_t;
-        }
-
-        if (isset($t)) {
+        } catch (Throwable $t) {
             $numTests = \count($this);
 
             for ($i = 0; $i < $numTests; $i++) {

diff --git a/tests/Regression/GitHub/1570.phpt b/tests/Regression/GitHub/1570.phpt
@@ -21,5 +21,7 @@ There was 1 risky test:
 1) Issue1570Test::testOne
 This test did not perform any assertions
 
+%s:14
+
 OK, but incomplete, skipped, or risky tests!
 Tests: 1, Assertions: 0, Risky: 1.
diff --git a/tests/TextUI/log-junit.phpt b/tests/TextUI/log-junit.phpt
@@ -85,5 +85,7 @@ There was 1 risky test:
 1) vendor\project\StatusTest::testRisky
 This test did not perform any assertions
 
+%s:42
+
 ERRORS!
 Tests: 7, Assertions: 2, Errors: 1, Failures: 1, Warnings: 1, Skipped: 1, Incomplete: 1, Risky: 1.
diff --git a/tests/TextUI/report-useless-tests-isolation.phpt b/tests/TextUI/report-useless-tests-isolation.phpt
@@ -21,5 +21,7 @@ There was 1 risky test:
 1) NothingTest::testNothing
 This test did not perform any assertions
 
+%s:14
+
 OK, but incomplete, skipped, or risky tests!
 Tests: 1, Assertions: 0, Risky: 1.
diff --git a/tests/TextUI/report-useless-tests.phpt b/tests/TextUI/report-useless-tests.phpt
@@ -20,5 +20,7 @@ There was 1 risky test:
 1) NothingTest::testNothing
 This test did not perform any assertions
 
+%s:14
+
 OK, but incomplete, skipped, or risky tests!
 Tests: 1, Assertions: 0, Risky: 1.
diff --git a/tests/TextUI/testdox-xml.phpt b/tests/TextUI/testdox-xml.phpt
@@ -58,5 +58,7 @@ There was 1 risky test:
 1) vendor\project\StatusTest::testRisky
 This test did not perform any assertions
 
+%s:42
+
 ERRORS!
 Tests: 7, Assertions: 2, Errors: 1, Failures: 1, Warnings: 1, Skipped: 1, Incomplete: 1, Risky: 1.