-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception "Serialization of 'Closure' is not allowed" when using assertEquals with processIsolation #1515
Comments
Hi, |
Yes it would. But you would also create a dependency from the comperator package to the full phpunit package which seems a little overkill. |
yeha, just realized that those are separate projects. thanks |
I have a very similar issue when running unit tests in my WordPress Plugin (thus using Note that I MUST run the tests in process isolation, otherwise they won't work. Replacing calls to The stack trace is the following:
|
Dear contributor, let me start by apologizing for not commenting and/or working on the issue you have reported or merging the pull request you have sent sooner. PHPUnit 5.0 was released today. And today I am closing all open bug reports and pull requests for PHPUnit and its dependencies that I maintain. Please do not interpret the closing of this ticket as an insult or a lack of interest in your problem. I am sorry for any inconvenience this may cause. If the topic of this ticket is still relevant then please open a new ticket or send a new pull request. If your ticket or pull request is about a defect then please check whether the issue still exists in PHPUnit 4.8 (which will received bug fixes until August 2016). If your ticket or pull request is about a new feature then please port your patch PHPUnit 5.0 before sending a new pull request. I hope that today's extreme backlog grooming will allow me to respond to bug reports and pull requests in a more timely manner in the future. Thank you for your understanding, |
This is a followup to #1351.
When using processIsolation in case of an error an exception is thrown and serialized. The trace might contain arguments that are (or contain) closures which can not be serialized and fail with a message like this
The issue has already been addressed (and fixed as far as I can tell) in #1351. This ticket also contains more details. But when using
assertEquals
this behavior still occurs, because aSebastianBergmann\Comparator\ComparisonFailure
is thrown in this case which does not inherit fromPHPUnit_Framework_Exception
.Related issues
Temporary workaround
Using
assertSame
instead ofassertEqauls
does not show the mentioned behavior.Proposed fix
The PHPUnit_Framework_Exception might be extracted to a shared library so it could be used in sebastianbergmann/comperator and sebastianbergmann/phpunit alike.
The text was updated successfully, but these errors were encountered: