Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support the parsing of options after the arguments #1739

Conversation

yvoyer
Copy link
Contributor

@yvoyer yvoyer commented Jun 4, 2015

Allow usage of options after the arguments (if any).

$phpunit --debug path/to/test.php --colors

Before: would ignore the --colors option
After: Parse all the options after the path

* Add tests for PHPUnit_Util_Getopt
@yvoyer yvoyer force-pushed the feature/parse-options-after-arguments branch from 39ab30f to 78222b2 Compare June 4, 2015 02:53
@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Jun 4, 2015
@sebastianbergmann sebastianbergmann added this to the PHPUnit 4.8 milestone Jun 4, 2015
@sebastianbergmann
Copy link
Owner

Merged manually.

@yvoyer
Copy link
Contributor Author

yvoyer commented Jun 8, 2015

@sebastianbergmann I just noticed a note (at the bottom) that no longer apply with this PR.

I made a PR to keep it consistent with this PR.

sebastianbergmann pushed a commit to sebastianbergmann/phpunit-documentation that referenced this pull request Aug 10, 2015
@ivicaned
Copy link

Before version 4.8.0 I was able to add custom parameters that was used by my own test suite, for example:
phpunit TestSuite --exclude-benchmarks
and it would exclude benchmark tests(based on same internal directory structure and code in TestSuite.php).
Now after this pull request is accepted, when I try to add additional parameters for our internal use, we get error:
unrecognized option --exclude-benchmarks

Is there a way to allow additional parameters to phpunit, that might be used only internally(so in case if phpunit do not recognize, just skip them and provide warning message to users once tests are completed)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants