Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing argument for PHPUnit_TextUI_TestRunner::run #2094

Closed
SanderKnape opened this issue Feb 24, 2016 · 0 comments
Closed

Missing argument for PHPUnit_TextUI_TestRunner::run #2094

SanderKnape opened this issue Feb 24, 2016 · 0 comments

Comments

@SanderKnape
Copy link

This closed issue mentions two different warning messages. The issue is closed but looking at the doRun function and its callee in the same class, there appears to be a missing argument there which causes the aformentioned PHP warnings. In my experience, both CircleCI and Codeship execute the tests through that callee and I see the warning messages. Locally though on my laptop, the doRun function is executed from the Command.php file, where the $exit parameter is provided and I therefore don't see any warnings.

Looks to me either the erroneous calling function needs to be changed, or the $exit parameter should be given a default. I don't know which is more appropriate. I can make a PR if someone enlightens me with the proper solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant