phpdbg_*() functions are scoped to PHPUnit\phpdbg_*()

[sebastianbergmann]

PHP-Scoper, for example, transforms this line

if (!\function_exists('phpdbg_start_oplog')) {

to

if (!\function_exists('PHPUnit\\phpdbg_start_oplog')) {

which, of course, does not work properly anymore.

[sebastianbergmann]

@theofidry @sebastianfeldmann How do we fix this? Is this something missing on PHPUnit's side (as in how we use PHP-Scoper) or is this a problem in PHP-Scoper (as in it should know that phpdbg_*() functions are built into PHP)?

[theofidry]

There is two solutions for it:

• Adding those PHPDBG functions to PHP-Scoper's reflector (see https://github.com/humbug/php-scoper/blob/master/src/Reflector.php#L26)
• Adding a PHPDBG stub to JetBrains' stubs

Those two are not mutually exclusive, just potentially redundant.

Also note that there is a discussion to allow this part to be directly configurable from the config (see humbug/php-scoper#303 (comment)) which would make it even faster to patch (as a workaround – it doesn't prevent having to patch upstream for a "cleaner" solution)

[theofidry]

Ah right, meanwhile the 3rd quick & dirty alternative is to leverage the patchers to replace the incorrect replacements

[sebastianbergmann]

I have created pull requests for both php-scoper and phpstorm-stubs which (hopefully) teach these two about the phpdbg_*() functions. I would rather not use a patcher (that I have to remove later) to address this problem.

[theofidry]

👍 will try to go through my OSS notifs tomorrow

[sebastianbergmann]

JetBrains/phpstorm-stubs#793 has been merged.

[sebastianbergmann]

@theofidry Any update on this? Thanks!

[theofidry]

Should be fixed in 0.13.2