-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration changes in patch versions #5970
Comments
I am totally aware that if the config is generated with 11.6 and the constraint is set to 11.5, that failing validation would be reasonable but I do not get how it can fail in patches. But maybe I'm missing something (probably added schema in a patch as it was forgotten in the initial minor release?). |
You probably mean 11.3.6 and 11.3.5 here. |
Nah, actuall was referring to 11.2 and 11.3 as downgrading to a lower minor could actually break stuff regarding config. I can see that, the question I have is: why wasn't that 11.4 then? I mean, that is a whole new feature which did not exist beforehand. 🤔 |
Summary
Hey there, I do experience issues with a (for me) very generic setup.
Current behavior
I receive XMLLint issues due to the fact that it seems that there were new options added in 11.3.1+:
How to reproduce
Use composer to require phpunit:
NOTE: I've added the version on purpose as composer is falling back to minor versions by default_
This actually installs phpunit (as of now) v11.3.6 which seems to have both attributes listed above and XMLLint is properly validating the config file.
Setup phpunit by running
vendor/bin/phpunit --generate-configuration
.This generates the config with the attributes included.
Since we want to verify that our dependencies do work with upper and lower bounds of constraints, we usually run:
This installs 11.3.0 (as per composer constraints) which does not have the attributes listed above and thus.
If we now executed XMLLint, the validation is actually failing.
Expected behavior
Staying in the same minor range (esp. when not switching between majors in the upper bound) should validate the XML config.
I'd expect that nothing would be dropped in minors and nothing would be added in patches. Is that reasonable?
I would expect this a bug but happy to discuss this further.
The text was updated successfully, but these errors were encountered: