Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Assertions (aka Import Atributes) are back at stage 3 so we should add them again #380

Closed
jogibear9988 opened this issue Apr 8, 2023 · 2 comments · Fixed by #381
Closed

Import Assertions (aka Import Atributes) are back at stage 3 so we should add them again #380

jogibear9988 opened this issue Apr 8, 2023 · 2 comments · Fixed by #381
Labels
enhancement
Milestone
3.0

Comments

@jogibear9988
Copy link
Contributor

see: https://github.com/tc39/proposal-import-attributes
@jogibear9988
Copy link
Contributor Author

we also need to rename the property "assertions" to "attributes", see : https://github.com/estree/estree/blob/master/experimental/import-attributes.md

@adams85 adams85 mentioned this issue Apr 9, 2023
Merged
@adams85 adams85 linked a pull request Apr 9, 2023 that will close this issue
Add import attributes feature #381
Merged
@adams85
Copy link
Collaborator

adams85 commented Apr 9, 2023 •
edited
Loading

PR is ready but let's not merge it yet. I wrote about the why in the PR description.

@adams85 adams85 added this to the 3.0 milestone Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Add import attributes feature sebastienros/esprima-dotnet
2 participants
@jogibear9988 @adams85