Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvments around IQuery and IQueryIndex #467

Open
MikeAlhayek opened this issue Dec 23, 2022 · 2 comments
Open

Improvments around IQuery and IQueryIndex #467

MikeAlhayek opened this issue Dec 23, 2022 · 2 comments

Comments

@MikeAlhayek
Copy link
Collaborator

Here are some recommendation around improving IQuery<> and IQueryIndex<>

  • Add a way to create multiple joins on the same index. Currently when With<TIndex> is called multiple time, we assumed that the users want to join on the same index. This is fine in most/default case, but I think it would be much more helpful to allow the user to change that behavior by adding an alias parameter like something like this
IQueryIndex<TIndex> With<TIndex>(Expression<Func<TIndex, bool>> predicate, string alias = "") where TIndex : class, IIndex

With this change, we can say I want to join the same index multiple time if needed. Each time, a different alias value will have to be provided. When the same alias is used, then we use the existing join.

@sebastienros
Copy link
Owner

Maybe that's what Any/All are doing, I don't remember. @deanmarcussen ?

@deanmarcussen
Copy link
Collaborator

Yeah I think that’s .Any and .All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants