Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should check "if ignored" and then check "if python file" #68

Closed
wlwg opened this issue Oct 1, 2018 · 1 comment
Closed

Should check "if ignored" and then check "if python file" #68

wlwg opened this issue Oct 1, 2018 · 1 comment

Comments

@wlwg
Copy link
Contributor

wlwg commented Oct 1, 2018

Currently in the logic of filtering files to run pylint against, it first checks if the file is python type and then checks if the file is ignored (
https://github.com/sebdah/git-pylint-commit-hook/blob/master/git_pylint_commit_hook/commit_hook.py#L226 )

It might be better to check "if ignored" first and then check "if python file". It makes sense in that there's no need of checking "if it's python file" if the file is ignored. Also it could sometimes avoid some pain as reported in #67.

@sebdah
Copy link
Owner

sebdah commented Oct 24, 2018

Resolved in 2.5.1.

@sebdah sebdah closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants