Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the point creating a promise if you not going to wait for it? #24

Open
midnight-wonderer opened this issue Sep 20, 2023 · 2 comments

Comments

@midnight-wonderer
Copy link

Not sure why you created a promise here just to ignore it without waiting for it to finish.
Could you help me understand the rationale?

@midnight-wonderer
Copy link
Author

This is problematic because if the queue in the event loop is empty, nodejs will exit at the (broken) promise chain without running onShutdown.
Depending on what is being done in onShutdown, this might mean something won't get cleaned up properly.

@sebhildebrandt
Copy link
Owner

@midnight-wonderer ... well hmmm I am also irritated ;-) Need to check it but it seems that you are right. Will provide a fix for it ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants