-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't Returns Mac's #65
Comments
Hi, does |
Seems to be an node issue, with node 7.x I got correct mac addresses, node 8.4 does not return correct mac addresses. See nodejs/node#13581 |
There is already a pull request in the node repo, that should fix this issue. |
@sebhildebrandt
|
Yes, os returns it correct but the node built-in function |
You could circumvent this issue temporarily till the node bug gets resolved by downgrading to Node v7 as, like @sebhildebrandt mentioned, the mac address detection works like a charm there. |
Anyway, I hope the node team will merge the pull request on their side soon ;-) |
I think you may close this issue now. |
I only wanted to report that i don't have any problems i droped this package already in favor of my own class that calls os and does exec |
@sebhildebrandt Maybe you can use https://github.com/node-modules/address as your dependency to get MAC address. Because it has a fallback solution to get the right MAC address during the wrong versions of Node.js. |
@XadillaX: I guess you are right, waiting for the pull request on node.js side will anyway not fix the problem that with some node.js you will have wrong MAC addresses. As I want to keep this library dependency free, I will implement a fallback code to get correct MAC versions. I will try to do it next week. And btw. thank you for your comments/suggestions! |
Just published a fix for that ... |
node 8.4
Ubuntu 17.10
The text was updated successfully, but these errors were encountered: