Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Broken REST Routes #159

Closed
jim380 opened this issue Jan 11, 2024 · 5 comments · Fixed by #326
Closed

🐛 Broken REST Routes #159

jim380 opened this issue Jan 11, 2024 · 5 comments · Fixed by #326
Labels
type: documentation 📚 Improvements or additions to documentation

Comments

@jim380
Copy link
Contributor

jim380 commented Jan 11, 2024

Overview

There's at least one REST route that's currently broken. Likely more. Some more urgent, some less. We need to fix them based on priority:

  • /cosmos/tx/v1beta1/txs?events=message.sender='seda...'

Investigation

After some investigation the /txs route broke exactly in commit 45395245601a363af836a3bb4a59a9385d4991cb.

Before Upgrading to SDK v0.50

/cosmos/tx/v1beta1/txs?events=message.sender='seda...' worked normally.

http://localhost:1317/cosmos/tx/v1beta1/txs?events=message.sender='seda1e32g7uv8pw7jrxdhtz7adxfws0vw6u9gzcxccq'

image

After Upgrading to SDK v0.50

Check out the commit prior, i.e. b4b6ed7acd017ebbccfe1a62cbdec053275a6847. And you will see the route no longer works.

http://localhost:1317/cosmos/tx/v1beta1/txs?events=message.sender='seda1e32g7uv8pw7jrxdhtz7adxfws0vw6u9gzcxccq'

🔴 image

@jim380 jim380 added the type: bug 🐛 Something isn't working label Jan 11, 2024
@mariocao mariocao added the priority: critical Must be fixed immediately label Jan 11, 2024
@hacheigriega
Copy link
Member

hacheigriega commented Jan 18, 2024

The correct route is now /cosmos/tx/v1beta1/txs?query=message.sender='seda...'

See cosmos/cosmos-sdk#14758

Tagging @Thomasvdam just in case this info is relevant to him :)

@yerycs
Copy link

yerycs commented Mar 27, 2024

Hi @hacheigriega @Thomasvdam
/cosmos/tx/v1beta1/txs?query=message.sender='seda...'
Above query returns following error message.

{
    "code": 3,
    "message": "must declare at least one event to search",
    "details": []
}

Could you let me know how to use query correctly?

@Thomasvdam
Copy link
Member

@yerycs I'm not sure which host you're trying to reach, but most likely they're using some proxying service that is not forwarding the query parameters. We had our proxy configured incorrectly and observed the same issue, so if you were using our endpoints this should be fixed.

@yerycs
Copy link

yerycs commented Mar 28, 2024

@Thomasvdam Please let me know your endpoints

@hacheigriega
Copy link
Member

Reopening the issue because it is indeed very confusing because the documentation is all incorrect. Looks like we have to update openapi.yml.

@yerycs Sorry I missed your comment. Which network are you trying to connect to? Testnet or Mainnet?

@hacheigriega hacheigriega reopened this Apr 19, 2024
@hacheigriega hacheigriega added type: documentation 📚 Improvements or additions to documentation and removed type: bug 🐛 Something isn't working priority: critical Must be fixed immediately labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation 📚 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants