Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add filter types Mode and StdDev #284

Closed
hacheigriega opened this issue Jun 18, 2024 · 1 comment · Fixed by #300
Closed

✨ Add filter types Mode and StdDev #284

hacheigriega opened this issue Jun 18, 2024 · 1 comment · Fixed by #300
Assignees
@hacheigriega @DeshErBojhaa
Labels
type: feature ✨ New feature or request

Comments

@hacheigriega
Copy link
Member

✨ Feature

The chain currently only supports None filter, but we hope to add two new filters: Mode and StdDev. Some preliminary work was done in PR #280 but was removed to prioritize solidifying the minimum tally requirement first. Both the corresponding unit testing and integration testing should be updated to cover these new types.
@hacheigriega hacheigriega added the type: feature ✨ New feature or request label Jun 18, 2024
@DeshErBojhaa
Copy link
Contributor

Mode is implemented here #290

@hacheigriega hacheigriega mentioned this issue Jul 16, 2024
Merged
@mariocao mariocao reopened this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacheigriega hacheigriega

@DeshErBojhaa DeshErBojhaa

Labels
type: feature ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Refactor filtering and adding std dev filter sedaprotocol/seda-chain
3 participants
@mariocao @hacheigriega @DeshErBojhaa