Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code climate SSL certificate error #95

Merged
merged 1 commit into from
Aug 11, 2015

Conversation

nunorafaelrocha
Copy link
Collaborator

No description provided.

@nunofgs
Copy link
Contributor

nunofgs commented Aug 10, 2015

It shouldn't be necessary to manually post the data according to codeclimate/php-test-reporter#3 (comment). Can you investigate?

@nunorafaelrocha nunorafaelrocha force-pushed the bugfix/travis-ssl-certificate branch 4 times, most recently from ec18600 to 072c5fd Compare August 10, 2015 21:39
@nunorafaelrocha
Copy link
Collaborator Author

According with Jonathan Powers on 10 August, the SSL error still persists in some projects and they were not able to fully resolve the issue.

So we will maintain the workaround for necessary time until codeclimate fully fix the issue.

@@ -12,10 +12,11 @@ before_script:
- composer self-update
- composer update --prefer-source

script: phpunit
script: vendor/bin/phpunit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't composer create symlinks for binaries?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis comes with a pre-installed version of phpunit. We want to ensure that all our tests uses the version that is on the composer.json

@nunorafaelrocha nunorafaelrocha force-pushed the bugfix/travis-ssl-certificate branch from 072c5fd to 002a0e3 Compare August 10, 2015 22:02
nunofgs added a commit that referenced this pull request Aug 11, 2015
Fix code climate SSL certificate error
@nunofgs nunofgs merged commit 3a3eeeb into master Aug 11, 2015
@nunofgs nunofgs deleted the bugfix/travis-ssl-certificate branch August 11, 2015 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants