Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support @babel/plugin-transform-typescript #24

Conversation

kepek
Copy link
Contributor

@kepek kepek commented Aug 28, 2019

Workaround for known limitations of @babel/plugin-transform-typescript.

Before:

// This file is automatically generated.
// Please do not change this file!
interface CssExports {
  addToCartButton: string;
  'addToCartButton--error': string;
  'addToCartButton--loading': string;
}
declare const cssExports: CssExports;
export = cssExports;

After:

// This file is automatically generated.
// Please do not change this file!
interface CssExports {
  addToCartButton: string;
  'addToCartButton--error': string;
  'addToCartButton--loading': string;
  superNestedLvl1: string;
}
export const cssExports: CssExports;
export default cssExports;

See more: https://babeljs.io/docs/en/babel-plugin-transform-typescript
Docs: https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require

kepek and others added 3 commits August 28, 2019 14:21
…xport structure;

Workaround for: @babel/plugin-transform-typescript

Before:

```ts
// This file is automatically generated.
// Please do not change this file!
interface CssExports {
  addToCartButton: string;
  'addToCartButton--error': string;
  'addToCartButton--loading': string;
}
declare const cssExports: CssExports;
export = cssExports;
```

After:
```ts
// This file is automatically generated.
// Please do not change this file!
interface CssExports {
  addToCartButton: string;
  'addToCartButton--error': string;
  'addToCartButton--loading': string;
  superNestedLvl1: string;
}
export const cssExports: CssExports;
export default cssExports;
```

See more: https://babeljs.io/docs/en/babel-plugin-transform-typescript
Docs: https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require
@dim882
Copy link

dim882 commented Oct 29, 2019

Do you know when this will be merged? It would be really helpful for me. Thanks!

Copy link
Collaborator

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mattcompiles mattcompiles changed the title Workaround for @babel/plugin-transform-typescript. Changed cssModuleE… fix: Support @babel/plugin-transform-typescript Oct 30, 2019
@mattcompiles mattcompiles merged commit 908d491 into seek-oss:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants