fix: Adding css-loader v4 support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Template update
mattcompiles
approved these changes
Sep 22, 2020
|
Before merging, just wondering why you committed with a breaking change message? From my perspective this change is backwards compatible? |
Oops, I think I made a mistake... No this is not a breaking change. Thanks for reviewing PR😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it for?
Currently, the library only supports css-loader up to version 3. From version 4, the local export becomes CSS_LOADER_EXPORT.locals instead of exports.locals. I would like to add the support for version 4. This is the fix for issue number 39: #39
What have I done?
Added the function to split content with CSS_LOADER_EXPORT.locals if splitting with exports.local fails. Then use the function instead.
Updated the css-loader version for testing.