This repository has been archived by the owner on Sep 14, 2021. It is now read-only.
fix: Change tertiaryLabel prop type to Object #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgk
requested review from
michaeltaranto,
georgespyropoulos,
dborysiewicz and
mattcompiles
dborysiewicz
approved these changes
Oct 31, 2018
dborysiewicz
suggested changes
Oct 31, 2018
trevorgk
force-pushed
the
tertiary-lbl-proptypes
branch
from
624b0aa
to
c2daba8
Compare
trevorgk
force-pushed
the
tertiary-lbl-proptypes
branch
from
c2daba8
to
ceb54d4
Compare
dborysiewicz
approved these changes
Oct 31, 2018
michaeltaranto
approved these changes
Oct 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tertiaryLabelflow type of theTextFieldcomponent was string, but this was not reflecting the use case.It is useful for consumers to be able to include a link (or potentially any other content) in this section. In the case of the Advertiser sign-in portal, we are including a forgot password link.
I have updated the
TextFieldcomponent flow type and also discovered that the prop type was missing in other components and included them in this PR as well.