Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

feat(Header): Add courses link to mobile site #598

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

wenkangjing
Copy link
Contributor

Add courses link in SKJ mobile site menu.

  • Design: no icon below Employer Site
  • Link to Seek Learning Course Directory site: https://www.seek.com.au/learning/
  • co.nz/learning has been redirect to its au equivalent, so safe to just use /learning on both domain

BREAKING CHANGE: n/a

Design:
image

@wenkangjing wenkangjing changed the title Add courses link to mobile site feat(Header): Add courses link to mobile site Jan 29, 2019
@wenkangjing
Copy link
Contributor Author

Thanks @michaeltaranto for raise the question about the SEO, courses link has been hard coded to au site to get rid of 301. Could you please re review the PR? Thanks.

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@wenkangjing wenkangjing merged commit 47ceb2c into master Jan 30, 2019
@wenkangjing wenkangjing deleted the add-courses-link-to-mobile-site branch January 30, 2019 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants