Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

fix(AccordionItem): Set height to auto #629

Merged
merged 4 commits into from
May 31, 2019
Merged

fix(AccordionItem): Set height to auto #629

merged 4 commits into from
May 31, 2019

Conversation

chardos
Copy link
Contributor

@chardos chardos commented May 28, 2019

This PR fixes:

  • The content being set to the incorrect initialState
  • Adds back the height being set to auto when the animation finishes. This accounts for content that could dynamically change size, such as textareas.

terenceduong
terenceduong approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@terenceduong terenceduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@chardos chardos changed the title Accordion bug fix(AccordionItem): Accordion bug May 29, 2019
@chardos chardos changed the title fix(AccordionItem): Accordion bug fix(AccordionItem): Set height to auto May 29, 2019
fmr
fmr approved these changes May 30, 2019
View reviewed changes
Copy link

@fmr fmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@chardos chardos merged commit 92dfa10 into master May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@terenceduong terenceduong terenceduong approved these changes

@fmr fmr fmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chardos @fmr @terenceduong