Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix kotlin gradle version for integrations #109

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fix(core): fix kotlin gradle version for integrations #109

merged 1 commit into from
Sep 23, 2019

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 23, 2019 •
edited
Loading

@bsneed bsneed requested a review from fathyb September 23, 2019 19:43
fathyb
fathyb approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@fathyb fathyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nitpicks:

  • Any reason to use 1.3.21 instead of 1.3.50?
  • Could you add which issues this fixes in the PR description and make sure it is in the commit description when merged? This will ensure the changelog is properly generated

@fathyb
Copy link
Contributor

fathyb commented Sep 23, 2019

Nevermind for the version! Just noticed we're already using 1.3.21 in the main module:

analytics-react-native/packages/core/android/build.gradle

Line 11 in 9511c98

classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.21'

@bsneed bsneed merged commit 3f4e3cc into master Sep 23, 2019
@oscb oscb deleted the bsneed/kotlin-fix branch February 23, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fathyb fathyb fathyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bsneed @fathyb