Add prettier-eslint

Author: fathyb

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   test:
     docker:
-      - image: circleci/node:4-browsers
+      - image: circleci/node:8-browsers
     steps:
       - checkout
       - run: npm config set "//registry.npmjs.org/:_authToken" $NPM_AUTH
@@ -18,7 +18,7 @@ jobs:
           path: junit-reports
   publish:
     docker:
-      - image: circleci/node:4-browsers
+      - image: circleci/node:8-browsers
     steps:
       - checkout
       - attach_workspace: { at: . }

.eslintrc

@@ -1,3 +1,3 @@
 {
-  "extends": "@segment/eslint-config/browser/legacy"
+  "extends": ["@segment/eslint-config/browser/legacy", "prettier"]
 }

.prettierrc

@@ -0,0 +1,3 @@
+{
+  "singleQuote": true
+}

Makefile

@@ -58,12 +58,13 @@ distclean: clean
 
 # Lint JavaScript source files.
 lint: install
-	@$(ESLINT) $(ALL_FILES)
+	yarn lint
+
 .PHONY: lint
 
 # Attempt to fix linting errors.
 fmt: install
-	@$(ESLINT) --fix $(ALL_FILES)
+	yarn format
 .PHONY: fmt
 
 # Run browser unit tests in a browser.

package.json

@@ -11,7 +11,18 @@
   ],
   "main": "lib/index.js",
   "scripts": {
-    "test": "make test"
+    "test": "make test",
+    "lint": "eslint \"./{lib,test}/**/*.js\"",
+    "format": "prettier-eslint --write --list-different \"./{lib,test}/**/*.{js,json,md}\"",
+    "precommit": "lint-staged"
+  },
+  "lint-staged": {
+    "linters": {
+      "*.{js,json,md}": [
+        "prettier-eslint --write",
+        "git add"
+      ]
+    }
   },
   "repository": {
     "type": "git",
@@ -38,26 +49,26 @@
     "@segment/isodate": "^1.0.2",
     "@segment/isodate-traverse": "^1.0.1",
     "@segment/prevent-default": "^1.0.0",
+    "@segment/send-json": "^3.0.0",
     "@segment/store": "^1.3.20",
     "@segment/top-domain": "^3.0.0",
     "bind-all": "^1.0.0",
-    "extend": "3.0.1",
     "component-cookie": "^1.1.2",
     "component-emitter": "^1.2.1",
     "component-event": "^0.1.4",
     "component-querystring": "^2.0.0",
     "component-type": "^1.2.1",
     "component-url": "^0.2.1",
     "debug": "^0.7.4",
+    "extend": "3.0.1",
     "inherits": "^2.0.1",
     "install": "^0.7.3",
     "is": "^3.1.0",
     "json3": "^3.3.2",
     "new-date": "^1.0.0",
     "next-tick": "^0.2.2",
     "segmentio-facade": "^3.0.2",
-    "uuid": "^2.0.2",
-    "@segment/send-json": "^3.0.0"
+    "uuid": "^2.0.2"
   },
   "devDependencies": {
     "@segment/analytics.js-integration": "^3.2.1",
@@ -66,8 +77,10 @@
     "compat-trigger-event": "^1.0.0",
     "component-each": "^0.2.6",
     "eslint": "^2.9.0",
+    "eslint-config-prettier": "^2.9.0",
     "eslint-plugin-mocha": "^2.2.0",
     "eslint-plugin-require-path-exists": "^1.1.5",
+    "husky": "^0.14.3",
     "jquery": "^3.2.1",
     "karma": "1.3.0",
     "karma-browserify": "^5.0.4",
@@ -79,8 +92,10 @@
     "karma-sauce-launcher": "^1.0.0",
     "karma-spec-reporter": "0.0.26",
     "karma-summary-reporter": "^1.5.0",
+    "lint-staged": "^7.2.0",
     "mocha": "^2.2.5",
     "phantomjs-prebuilt": "^2.1.7",
+    "prettier-eslint-cli": "^4.7.1",
     "proclaim": "^3.4.1",
     "sinon": "^1.7.3",
     "watchify": "^3.7.0"

test/.eslintrc

@@ -1,3 +1,3 @@
 {
-  "extends": "@segment/eslint-config/mocha"
+  "extends": ["@segment/eslint-config/mocha", "prettier"]
 }