Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Should be able to return the rest of the batch when the stream end #7

Open
bobylito opened this issue Sep 18, 2015 · 5 comments
Open

Comments

@bobylito
Copy link

When a stream contains a number of items that is not a strict multiply of the batch size, it results in some items that are not passed to then next stream process.

@eric-radiant
Copy link

That would be great to have fixed.

@roccomuso
Copy link

roccomuso commented Jul 17, 2018

Totally agree. I published a package that solves this issue: batched-stream

@richardscarrott
Copy link

@bobylito
Copy link
Author

bobylito commented Dec 6, 2019

I think it already does https://github.com/segmentio/batch-stream/blob/master/lib/index.js#L38?

When I initially reported the issue, it was not working like I expected as far as I can recall. The file was last modified before I opened the issue. So either it is not fixed, or I reported something incorrectly 😅

I think I should provide a test case for that :)

@bobylito
Copy link
Author

bobylito commented Dec 6, 2019

I think I should provide a test case for that :)

On the other hand, is it even worth it? There is a PR hanging sincw 2014 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants