-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract & expose Dialog utility components #1466
Labels
Comments
Hey @brandongregoryscott I would like to contribute to this issue. Can you please assign this issue to me? |
Sure thing! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extract the following JSX/functions from
Dialog.js
and expose them as standalone components:DialogHeader
evergreen/src/dialog/src/Dialog.js
Lines 113 to 132 in 108a5bc
DialogBody
evergreen/src/dialog/src/Dialog.js
Lines 207 to 217 in 108a5bc
DialogFooter
evergreen/src/dialog/src/Dialog.js
Lines 134 to 169 in 108a5bc
These are already mostly "themed" as regular components, but may need some slight tweaks during extraction:
evergreen/src/dialog/src/Dialog.js
Lines 109 to 111 in 108a5bc
https://github.com/segmentio/evergreen/blob/master/src/themes/default/components/dialog-header.js
https://github.com/segmentio/evergreen/blob/master/src/themes/default/components/dialog-body.js
https://github.com/segmentio/evergreen/blob/master/src/themes/default/components/dialog-footer.js
These components should be attached to the
Dialog
component so they can be used for composition if needed, similar to theEmptyState
component:evergreen/src/empty-states/src/EmptyState.js
Lines 166 to 167 in 108a5bc
The text was updated successfully, but these errors were encountered: