-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog allows user to tab elements in the background #1551
Labels
Comments
You're right, it should be trapping focus inside. Accessibility hasn't been top of mind up to this point |
Hi guys! Just wanted to let you now I'm on it. |
As of thorough research it is clear that making a custom focus trapping technique is not advisable. therefore I found a well known and used library react-focus-trap to achieve desired improvement. Creating a pull request. |
brandongregoryscott
added
the
accessibility
Issue regarding web accessibility functionality
label
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For my understanding the Dialog component should only enable tabbing in the current dialog context, not in the background of it.
https://evergreen.segment.com/components/dialog
Working w3c example: https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/alertdialog.html
The text was updated successfully, but these errors were encountered: