Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't be Arch-specific for the build system #33

Open
romanrm opened this issue Jun 23, 2024 · 1 comment
Open

Please don't be Arch-specific for the build system #33

romanrm opened this issue Jun 23, 2024 · 1 comment

Comments

@romanrm
Copy link

romanrm commented Jun 23, 2024

Hello,

Even if this builds an Arch image, it doesn't have to be that this only works on an Arch system to build.

For example I launch the scripts on a Debian machine. First attempt:

bash: ./1_compile.sh: /usr/bin/sh: bad interpreter: No such file or directory

What is wrong with the normal "/bin/sh"?

Second attempt:

./consts.sh: line 61: pacman: command not found
Please install 'riscv64-linux-gnu-gcc'

Sorry I got no "pacman" on my machine, meanwhile /usr/bin/riscv64-linux-gnu-gcc-12 is happily present and ready to be executed. Why not just check for presence of the compiler, not of an Arch package of a compiler.

Feels very petty and hostile, like "f u if you use a different distro", we will specifically hardcode our own little incompatible ways so this doesn't work on your system.

@sehraf
Copy link
Owner

sehraf commented Jun 23, 2024

I've fixed the first error by making it distro independent.

Regarding the second, I cannot (and will not) maintain different distros, if this sounds or feels hostile, deal with it - if I remove that check, people will complain that the script isn't working because they are missing packages.
Nevertheless, I'm open for PRs, so feel free to add a check for Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants