Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SailOTP doesn't recognize a QR code for github #49

Open
ddobrev opened this issue May 9, 2021 · 1 comment
Open

SailOTP doesn't recognize a QR code for github #49

ddobrev opened this issue May 9, 2021 · 1 comment

Comments

@ddobrev
Copy link

ddobrev commented May 9, 2021

Regardless of the size of the QR code and the mode I put the scanner in by clicking the preview, nothing happens. The built-in camera application in Sailfish, on the contrary, recognizes it almost immediately even when the image is small. So does Foil Auth. I also copied the secret key these gave me and then added it to SailOTP which was then able to work and generate correct codes. So in general it works, it just failed to recognize my QR code.
My Sailfish is at version 4.0.1.48, SailOTP is latest.

@seiichiro0185
Copy link
Owner

Hi,

well yes, the QR codereader in SailOTP is a dirty hack from the early days of SailfishOS, which also means it's not very good. Unfortunately I didn't have the time so far to do a rewrite of it, or investigate if or how it is possible to use the native one from the Camera (open SailOTP if TOPT / HOTP URL is found or something like this).

I'll take a look at this when I find the time, or gladly accept pull requests for a fixes or a rewritten QR codereader part in the meantime.

My preferred solution would be to use the native one from the SFOS Camera, to not reinvent the wheel for something thats already there in the Base OS. Not sure if thats possible at the moment (and allowed in Harbour Apps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants